Fix home dir issue in export command #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 69.86% 69.68% -0.18%
==========================================
Files 28 28
Lines 2389 2421 +32
==========================================
+ Hits 1669 1687 +18
- Misses 605 616 +11
- Partials 115 118 +3
|
4 tasks
ethanfrey
approved these changes
Dec 11, 2020
| logger log.Logger, db dbm.DB, traceStore io.Writer, height int64, forZeroHeight bool, jailAllowedAddrs []string, | ||
| appOpts servertypes.AppOptions) (servertypes.ExportedApp, error) { | ||
|
|
||
| var wasmApp *app.WasmApp | ||
| homePath, ok := appOpts.Get(flags.FlagHome).(string) | ||
| if !ok || homePath == "" { | ||
| return servertypes.ExportedApp{}, errors.New("application home not set") |
| if height != -1 { | ||
| wasmApp = app.NewWasmApp(logger, db, traceStore, false, map[int64]bool{}, "", uint(1), app.GetEnabledProposals(), appOpts) | ||
| wasmApp = app.NewWasmApp(logger, db, traceStore, false, map[int64]bool{}, homePath, uint(1), app.GetEnabledProposals(), appOpts) |
There was a problem hiding this comment.
wow, we literally just passed "" in there. surprised other code worked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #334
Manually tested with a local instance and
wasmd exportand ``wasmd --home=/ export`