Implement IBC contract support #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
==========================================
- Coverage 56.13% 55.26% -0.88%
==========================================
Files 34 39 +5
Lines 3461 4015 +554
==========================================
+ Hits 1943 2219 +276
- Misses 1373 1617 +244
- Partials 145 179 +34
|
ethanfrey
approved these changes
Jan 28, 2021
There was a problem hiding this comment.
Great (team)work here!
One minor nit, then let's merge this. And extend the functionality with more PRs to come.
Also: should we make a note on the README that master is not to be used except local tests? We are based on git commits of wasmvm and cosmwasm, and interfaces are in flux.
This has not changed afaik. Anything before v1.0.0 should not be considered stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates IBC support for Wasm contracts. 🎉
Entry points
Wasm contracts can implement the following entry points to become an IBC port assigned automatically:
wasm.<contract-address>Channel lifecycle
A contract can receive/send packets via channels.
See IBC flow
Handshake start:
OnChanOpenInit,OnChanOpenTry,pub fn ibc_channel_openHandshake confirmation:
OnChanOpenAck,OnChanOpenConfirmpub fn ibc_channel_connectClose:
OnChanCloseInit,OnChanCloseConfirmpub fn ibc_channel_closePacket lifecycle
Packets transport data on the application level. See [IBC flow](https://github.com/cosmos/ics/tree/master/spec/ics-004-channel-and-packet-semantics#packet-flow--handling]
pub fn ibc_packet_receivepub fn ibc_packet_ackpub fn ibc_packet_timeout(New IBC messages
TransferMsg- start an ICS-20 transfer using the cosmos-sdk IBC/transfer moduleSendPacket- send an IBC data package on an existing channelCloseChannelMsg- initiate close procedure for an existing IBC channelCredits
This PR contains also a lot of work and feedback from @ethanfrey and @webmaster128 👏