Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove internal package #464

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Remove internal package #464

merged 2 commits into from
Mar 19, 2021

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 18, 2021

After #463

Moves types and keeper one level up.

@alpe alpe added the extension point Makes the system easier to extend or test label Mar 18, 2021
@alpe alpe force-pushed the no_internal_pkg branch from 484b518 to 5c9af06 Compare March 18, 2021 15:55
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this when CI is.
Please add an entry to CHANGELOG. This is breaking for all imports.

@alpe alpe force-pushed the no_internal_pkg branch from 9efcd02 to fa58484 Compare March 19, 2021 08:31
@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #464 (fa58484) into master (63fe568) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
+ Coverage   56.76%   56.80%   +0.04%     
==========================================
  Files          40       40              
  Lines        4385     4385              
==========================================
+ Hits         2489     2491       +2     
+ Misses       1685     1684       -1     
+ Partials      211      210       -1     
Impacted Files Coverage Δ
x/wasm/client/cli/genesis_msg.go 71.96% <ø> (ø)
x/wasm/client/cli/gov_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/new_tx.go 0.00% <ø> (ø)
x/wasm/client/cli/query.go 0.00% <ø> (ø)
x/wasm/client/cli/tx.go 26.24% <ø> (ø)
x/wasm/handler.go 74.28% <ø> (ø)
x/wasm/ibc.go 59.37% <ø> (ø)
x/wasm/keeper/api.go 60.00% <ø> (ø)
x/wasm/keeper/authz_policy.go 100.00% <ø> (ø)
x/wasm/keeper/genesis.go 87.87% <ø> (ø)
... and 24 more

@alpe
Copy link
Contributor Author

alpe commented Mar 19, 2021

Builds now. Sorry was in a hurry and should have done a draft PR instead. Good to have CI covering me 😅

@alpe alpe merged commit d914266 into master Mar 19, 2021
@alpe alpe deleted the no_internal_pkg branch March 19, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension point Makes the system easier to extend or test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants