-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ecosystem convention for keeper names in app.go #882
Conversation
My preference here is to first: The specific reason is that go 1.18 will change some of the supported linters. We could then dial in on the ones that we think are valuable, and also exclude anything that isn't. |
Thanks for bringing this up! 🌻 I have seen public fields in other apps, too. I was always wondering why break encapsulation without a need.
what do you mean with this? |
@alpe - the practice that I openly recommend to other developers when constructing app.go is to very literally copy and paste. Being generally the same as other chains makes that easier. re: encapsulation, and having a standard on these-- I have wondered same as yourself. from the perspective of someone working on Juno, who'd like to move changes between wasmd and juno, adopting this standard would make upstreaming work into wasmd easier. |
I agree 💯 with you that we should have a standard and the same format in wasmd, osmosis and Juno. However, Alex's question was why Juno's approach is better than the wasmd approach. Maybe you or another Juno dev can explain why these are needed to be public. (I have some ideas, but I prefer feedback from actual users) |
@ethanfrey honestly I don't see a reason in either direction, 🤣 I think this is purely about following convention and making merges easier. |
Codecov Report
@@ Coverage Diff @@
## main #882 +/- ##
=======================================
Coverage 59.14% 59.14%
=======================================
Files 51 51
Lines 6198 6198
=======================================
Hits 3666 3666
Misses 2265 2265
Partials 267 267
|
Thanks for the PR and bringing this topic up! I was pending for a while now due to my other priorities but I polished your commits in #951. |
This PR changes keeper names in app.go to match the commonly used ecosystem conventional style, which: