Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated go.mod to make install work on Apple M1 #967

Closed
wants to merge 1 commit into from

Conversation

sajanjswl
Copy link

make install fails on Apple M1 due to the older version used for

github.com/keybase/go-keychain
github.com/zondax/hid

This Pr fixes this.

Signed-off-by: sajan jaiswal <sjnjaiswal@gmail.com>
@sajanjswl sajanjswl requested a review from alpe as a code owner August 29, 2022 11:06
@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #967 (ebc4f8a) into main (49d571e) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #967      +/-   ##
==========================================
- Coverage   59.34%   59.31%   -0.04%     
==========================================
  Files          51       51              
  Lines        6221     6221              
==========================================
- Hits         3692     3690       -2     
- Misses       2264     2265       +1     
- Partials      265      266       +1     
Impacted Files Coverage Δ
x/wasm/keeper/keeper.go 88.33% <0.00%> (-0.34%) ⬇️

@alpe
Copy link
Contributor

alpe commented Aug 29, 2022

Thanks for the PR!
We has some similar one recently where I opened #957 for discussion.

@alpe alpe added the blocked label Aug 29, 2022
@alpe
Copy link
Contributor

alpe commented Sep 7, 2022

I am closing this in favour of #985. Can you confirm that it works for you, when merged?

I saw that gaia has pinned github.com/zondax/hid to the v0.9.0 release. I don't feel comfortable to upgrade this dependency without more discussion.

@alpe alpe closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants