Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tendermint-db dependency #405

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Remove tendermint-db dependency #405

merged 2 commits into from
Mar 8, 2023

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 7, 2023

Resolves #404

  • Inline Tendermint's Interator interface
  • Inline Tendermint's MemDB for testing

@alpe alpe requested a review from webmaster128 March 7, 2023 08:34
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

Not sure when to best merge this though. Does this change and API?

@webmaster128
Copy link
Member

I take care of the CI fail. Not related to your work.

@DongLieu
Copy link

I have an Interator Interface problem.

Currently, Wasmvm's KVStore and Cosmos-SDK's KVStore differ in the Iterator interface.

Specifically in the main SDK branch:
Iterator(start, end []byte) (Iterator, error)
with Iterator = dbm.Iterator (dbm “github.com/cosmos/cosmos-db”)

For SDK branch using cometbft:
Iterator(start, end []byte) Iterator
with Iterator = dbm.Iterator (dbm “github.com/cometbft/cometbft-db”)

Wasmvm:
Iterator(start, end []byte) Iterator
with 'Iterator = types.Iterator' ("github.com/CosmWasm/wasmvm/types")

This leads to Interator incompatibility.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for CometBFT
3 participants