Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Cosmic-Ide #151

Merged
merged 4 commits into from
Jul 29, 2022
Merged

Improve Cosmic-Ide #151

merged 4 commits into from
Jul 29, 2022

Conversation

aikrq
Copy link
Contributor

@aikrq aikrq commented Jul 29, 2022

Added a lot of changes that I'm too lazy to break into
good commits.

aikrq and others added 3 commits July 29, 2022 13:34
revert previous commit

revert previous commit

update sora-editor

chore(deps): bump language-java from 0.15.0 to 0.15.1 (#149)

Bumps [language-java](https://github.com/Rosemoe/sora-editor) from 0.15.0 to 0.15.1.
- [Release notes](https://github.com/Rosemoe/sora-editor/releases)
- [Commits](Rosemoe/sora-editor@0.15.0...0.15.1)

---
updated-dependencies:
- dependency-name: io.github.Rosemoe.sora-editor:language-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

refactor: Refactor code and improve some comments

Fix annoying "No class roots are found in JDK path: " error in kotlinc

change import name to use updated package name

fix package name extraction system

feat: Improve UI

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Use our Typography System

Remove duplicate style

Added fonts

Use CosmicIde TextAppearance instead of Default TextAppearance

No commit message

No commit message

Get ColorControlNormal color for Completion Stroke color

fix: Use another attr for getting color

temp: Temporarily disable nonTransitiveRClass

No commit message

Use colorOutline for stroke color

Enable nonTransitiveRClass

Use google's R class for getting attrs

Do not import google's R class

Add insets for landscape orientation

Add insets for landscape orientation

feat: Highlight current cursor position for completion item

Add missing import

Fix null cannot be converted to int

Use trim for project name check

Add BaseActivity

Remove extra parenthesis

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Fix typo

Fix typo

No commit message

No commit message

Use constants string expression

Recreate activity when current theme has changed

No commit message

No commit message

Add missing import

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Save current file when another activity comes into the foreground

:skull:
revert previous commit

revert previous commit

update sora-editor

chore(deps): bump language-java from 0.15.0 to 0.15.1 (#149)

Bumps [language-java](https://github.com/Rosemoe/sora-editor) from 0.15.0 to 0.15.1.
- [Release notes](https://github.com/Rosemoe/sora-editor/releases)
- [Commits](Rosemoe/sora-editor@0.15.0...0.15.1)

---
updated-dependencies:
- dependency-name: io.github.Rosemoe.sora-editor:language-java
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

refactor: Refactor code and improve some comments

Fix annoying "No class roots are found in JDK path: " error in kotlinc

change import name to use updated package name

fix package name extraction system

feat: Improve UI

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Use our Typography System

Remove duplicate style

Added fonts

Use CosmicIde TextAppearance instead of Default TextAppearance

No commit message

No commit message

Get ColorControlNormal color for Completion Stroke color

fix: Use another attr for getting color

temp: Temporarily disable nonTransitiveRClass

No commit message

Use colorOutline for stroke color

Enable nonTransitiveRClass

Use google's R class for getting attrs

Do not import google's R class

Add insets for landscape orientation

Add insets for landscape orientation

feat: Highlight current cursor position for completion item

Add missing import

Fix null cannot be converted to int

Use trim for project name check

Add BaseActivity

Remove extra parenthesis

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Fix typo

Fix typo

No commit message

No commit message

Use constants string expression

Recreate activity when current theme has changed

No commit message

No commit message

Add missing import

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

No commit message

Save current file when another activity comes into the foreground

:skull:
@aikrq aikrq requested a review from PranavPurwar July 29, 2022 07:07
Copy link
Member

@PranavPurwar PranavPurwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole new theme looks nice, but you could have just pushed the changes instead of a PR ._.

@PranavPurwar PranavPurwar merged commit efdc80f into Cosmic-Ide:main Jul 29, 2022
@aikrq
Copy link
Contributor Author

aikrq commented Jul 29, 2022

The whole new theme looks nice, but you could have just pushed the changes instead of a PR ._.

I want you to comment on what you didn't like and I'll change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants