Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue-29, unbalanced calls to begin/end appearance transitions #42

Merged
merged 1 commit into from
Jul 19, 2018
Merged

Conversation

OrkhanAlikhanov
Copy link
Contributor

@OrkhanAlikhanov OrkhanAlikhanov commented Jul 16, 2018

Fixed issue #29. Calling {begin,end}AppearanceTransition methods for modal transitions was causing the issue since UIKit was already calling them internally.

I did rigorous testing after fixing the issue with multiple setups (TabsContoller, NavigationDrawer, NavigationContoller, BottomNavigationBar) to try various transitions types, it never showed up again. I examined the view{Will,Did}{Appear,Disappear} call trace and it was exactly same for Motion and UIKit modal transitions. Example trace:

viewWillDisappear AppRootController
viewWillDisappear NavigationController
viewWillDisappear BottomNavigationController
viewWillAppear ModalViewController
viewDidAppear ModalViewController
viewDidDisappear AppRootController
viewDidDisappear NavigationController
viewDidDisappear BottomNavigationController
viewWillDisappear ModalViewController
viewWillAppear AppRootController
viewWillAppear NavigationController
viewWillAppear BottomNavigationController
viewDidAppear AppRootController
viewDidAppear NavigationController
viewDidAppear BottomNavigationController
viewDidDisappear ModalViewController

Calling {begin,end}AppearanceTransition methods for modal transitions
was causing the issue since UIKit was already calling them that internally
@daniel-jonathan daniel-jonathan changed the base branch from master to development July 19, 2018 16:07
@daniel-jonathan
Copy link
Member

Don't forget to send PRs to the development branch.

@daniel-jonathan daniel-jonathan merged commit c72a732 into CosmicMind:development Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants