Fixed issue-44, view is hidden below status bar during call #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrkhanAlikhanov
changed the title
daniel-jonathan
approved these changes
Jul 31, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #44. When in-call, hotspot, or recording status bar is enabled, just after (custom) modal dismissal transition animation ends
UITransitionViewis removed from the hierarchy and that removal was movingrootViewController.view20 points upwards, pushingviewbeneath statusbar and leaving a black gap at the bottom. The PR fixes this by pushing it 20px downwards, the work thatUITransitionViewshould ideally have done after custom modal dismissal.Also fixed issue #43