Updates HMC sampler to recent TFP version #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will try to clean In the mean time, you can take a look to this notebook https://github.com/CosmoStat/jax-lensing/blob/master/papers/Remy2021/PosteriorSampling.ipynb, which does more or less the same thing as |
|
This PR is solved by #47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will aim to bring our score-based samplers up to date with recent TFP version. Mainly they have introduced new arguments for the samplers.
This is currently just a draft PR, only updated the HMC sampler but not the temperedMC class.... because I gave up trying to turn the sample_maps.py script into a notebook >.< Which motivates #45