Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Res plots #569

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Res plots #569

merged 3 commits into from
Jun 9, 2022

Conversation

martinkilbinger
Copy link
Contributor

@martinkilbinger martinkilbinger commented May 31, 2022 •
edited by sfarrens
Loading

Summary

Added Tobias' config file for validation of joint SP v1.0.2 star catalogue.

Reviewer Checklist

Reviewers should tick the following boxes before approving and merging the PR.

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger added the enhancement New feature or request label May 31, 2022
@martinkilbinger martinkilbinger added this to the Summer 2022 patch milestone May 31, 2022
@martinkilbinger martinkilbinger self-assigned this May 31, 2022
@sfarrens
Copy link
Member

sfarrens commented Jun 8, 2022

Since there are no changes to the code, I don't think much review is required. I am happy to merge this. @tobias-liaudat please let me know if you have any comments before I do so.

@tobias-liaudat tobias-liaudat merged commit 22c10da into CosmoStat:develop Jun 9, 2022
@sfarrens sfarrens mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-liaudat tobias-liaudat tobias-liaudat approved these changes

@sfarrens sfarrens sfarrens approved these changes

Assignees

@martinkilbinger martinkilbinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
Summer 2022 patch
Development

Successfully merging this pull request may close these issues.
3 participants
@martinkilbinger @sfarrens @tobias-liaudat