-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address CWA 2022 002 #178
Address CWA 2022 002 #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dockerfile needs to be updated as well. Otherwise the old static library (.a) is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:).
This looks great and I've test-compiled on my machine as well
See
for the changes needed to work with the latest static library. Also there is https://github.com/CosmWasm/wasmvm/wiki/Linking-wasmvm_muslc to explain the advanced linking required from beta9 on. |
Yep, just spotted the dockerfile issue. Also noticed you've coined a new wasmd, so will just bump 0.24 to that version. Thanks @webmaster128 |
…e with new wasmd static libs
Aha, of course I need to update the CI steps as well. Probably the docker packages too. Right |
Also check https://github.com/CosmWasm/wasmd/wiki/Maintainer-notes for how to do the different docker builds in the multi-architecture world. Also note: there are no consensus guarantees for ARM yet. Use it in a client, dev network or read-only node. But not on a validator. |
I am going to delete the dockerfile so that we can reduce scope and get this merged. @webmaster128 thank you for your review! |
removed from juno repo to reduce scope
I should give some context on deleting the dockerfile. I would prefer to build the rust library here. When we don't build everything from source, we invite problems like the one that we saw here. Anyone know if we can easily recreate the contract ci stuff without a dockerfile? Another alternative is later when I've more time I can write separate arm and x86 dockerfiles. This is because when i use env and arg for multiarch, it never works out right. |
this is deleted because the script it depends on is no longer present. We should restore this functionality.
deleting this because we don't have a dockerfile at the moment
when deleting the dockerfile there will also be an error in release ci |
I'm not against this approach. But please note that now you are not building libwasmvm here. You are using the shared libraries libwasmvm.dylib and libwasmvm.so via the Go dependency from git. This makes it a bit easier for some use cases, but gives you dynamically linked glibc Linux builds (Intel only) and dynamically linked Mac build (Intel and ARM) which might not be desired. There is probably no straight forward Alpine support that way. |
Reinstating Dockerfile in #179 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so we regressed after this?
This PR installs beta7, not beta10 because beta7 > beta10. See
|
Bump wasmvm to patch vulnerability