CGS Update (part 2) #3034

Szymekk44 · 2024-06-20T12:14:44Z

Added

FAST GetImage (SVGAII & VBE)
DrawCroppedImage (You can now draw wallpaper cropped by your taskbar height!)
DrawRawPoint
GetRawPoint
DrawRectangle is now faster!
Draw array for int[] (fast as draw image)
VBE Bugfixes
Finished preventOffBoundPixels (now its working for left side and right side(CGS Update part 1))
aaand PCIe by @Samma2009

blackneeed

Seems good, except when you want to draw an alpha rectangle. You cant do that since your directly putting it onto the canvas with no alpha blending.

valentinbreiz

Thanks for your changes on CGS! Could you also add a few tests for your changes? :)

source/Cosmos.Core/MemoryBlock.cs

source/Cosmos.System2/Graphics/Canvas.cs

source/Cosmos.System2/Graphics/SVGAIICanvas.cs

source/Cosmos.System2/Graphics/VBECanvas.cs

Szymekk44 · 2024-07-08T22:58:16Z

Okay its ready!
Also I quite don't know how to add tests and well what to test ;p

Epiczhul · 2024-07-20T18:38:38Z

nice work

Epiczhul

It looks nice! and works!

Epiczhul

Looks veryyy nice

Samma2009 · 2024-08-13T14:59:40Z

apparently we are having some technicall issues with json files and broom pulling epiczhul's stuff

quajak

Thank you for your work.

It would be great if you can add a docstring to all public methods you added but its not required.

quajak · 2024-08-13T14:51:26Z

source/Cosmos.Core/ACPI.cs

 using System.Runtime.InteropServices;

-namespace Cosmos.Core
+namespace MACPI.Cosmos.HAL.PCIE


Why are we changing the namespace?

quajak · 2024-08-13T14:53:14Z

source/Cosmos.Core/ManagedMemoryBlock.cs

@@ -154,6 +154,20 @@ public unsafe void Copy(int aStart, int[] aData, int aIndex, int aCount)
            }
        }

+        public unsafe void Get(int aStart, int[] aData, int aIndex, int aCount)
+        {
+            // TODO throw exception if aStart and aCount are not in bound. I've tried to do this but Bochs dies :-(


This should no longer be an issue and can be checked

quajak · 2024-08-13T14:55:31Z

source/Cosmos.Core/ACPI.cs

            }

-            int length = addr;
-            ptr -= 4;
+            Console.WriteLine("[ACPI] ACPI Initialized");


I thought we wanted to get rid of non-user controllable WriteLines during boot

quajak · 2024-08-13T14:56:03Z

source/Cosmos.Core/PCIE/PCIDevice.cs

+using System;
+using Cosmos.Core;
+
+namespace Cosmos.HAL.PCIE


namespace and directory dont match

quajak · 2024-08-13T14:56:55Z

source/Cosmos.Core/PCIE/PCIDevice.cs

+
+            PCIExpress.Initialize();
+
+            Console.Write("[PCI] PCI Initialized. ");


Do we need this writes?

hi, leaving them there is best practice because you will have feedback of the PCI and PCIE initialization

Could we allow the user to enable this feedback when they want it but also give them a way to disable it?

quajak · 2024-08-13T14:57:37Z

source/Cosmos.Core/PCIE/PCIExpress.cs

+using System.Runtime.InteropServices;
+using PCIDevice = Cosmos.HAL.PCIE.PCIDevice;
+
+namespace Cosmos.HAL.PCIE


quajak · 2024-08-13T14:59:37Z

source/Cosmos.System2/Graphics/Canvas.cs

+        /// <param name="maxHeight">Max image height to display</param>
+        public virtual void CroppedDrawImage(Image image, int x, int y, int maxWidth, int maxHeight, bool preventOffBoundPixels = true)
+        {
+


Why is this left empty?

i don't know tho i could fix it

quajak · 2024-08-13T15:02:01Z

source/Cosmos.Debug.Kernel.Plugs.Asm/packages.lock.json

@@ -11,25 +11,27 @@
          "Microsoft.NETCore.Platforms": "1.1.0"
        }
      },


Why is this dependency added?

i think i left a using from when i was testing it

Samma2009 · 2024-08-13T15:05:23Z

Thank you for your work.

It would be great if you can add a docstring to all public methods you added but its not required.

hi, can you please not merge as of now, i am trying to fix some issues with compileing and also json and dependency stuff, my visual studio messed up the repo

i am leaving dependencies and json to @SzymekkYT

Samma2009 · 2024-08-16T13:59:10Z

@MishaProductions all of the json files have been fixed.... could you merge (sorry for ping)

Cge update

Cge update2

Szymekk44 · 2024-09-21T10:29:28Z

Uhh yeah i wanted to make a new PR without Samma's PCIe but i guess github said no

Szymekk44 added 6 commits June 20, 2024 13:03

Drawing Raw Point (raw argb)

c4de75d

Faster DrawRectangle

f6937c9

GetRawPoint & Basic GetImage

4b3ee4d

Finished GetRawColor and faster SVGAII GetImage

e47e504

VBE DrawImage change and added CroppedDrawImage

5d9e075

Merge branch 'CosmosOS:master' into master

2feb8c1

blackneeed reviewed Jun 22, 2024

View reviewed changes

valentinbreiz requested changes Jul 2, 2024

View reviewed changes

More summaries, alpha rectangles

dda9df1

Szymekk44 requested a review from valentinbreiz July 8, 2024 22:59

MishaProductions and others added 3 commits July 10, 2024 07:44

Merge branch 'master' into master

7bad71f

added preventOffBoundPixels in summary

289270e

Merge branch 'master' of https://github.com/SzymekkYT/Cosmos

a3540b0

Epiczhul approved these changes Jul 21, 2024

View reviewed changes

Szymekk44 and others added 9 commits July 28, 2024 12:29

Fixed VBE getimage()

f064006

Faster VBE GetImage

2036880

Fixed SVGAII image drawing (x and y < 0)

f1bedae

Merge branch 'master' into master

d290822

New DrawArray methods, VBE bugfix

6f38e13

Small VBE bugfix

da5e7ac

Added PCIE

b00577e

Update PCIExpress.cs

8d6fa08

Delete source/Cosmos.Debug.Kernel.Plugs.Asm/packages.lock.json

c5b44ce

quajak requested changes Aug 13, 2024

View reviewed changes

fix power stuff

a770c34

Samma2009 and others added 10 commits August 13, 2024 17:10

change of comments

155b893

Merge branch 'master' of https://github.com/SzymekkYT/Cosmos

f047cd9

Fixed namespaceing

98406c5

i am leaving dependencies and json to @SzymekkYT

Update PCIExpress.cs

01342ae

Merge branch 'master' into master

7f19fbd

Add files via upload

d8f0aad

Update packages.lock.json

d117063

Update packages.lock.json

98bb00f

Update packages.lock.json

3375aab

Update packages.lock.json

ac464df

Szymekk44 requested a review from quajak August 17, 2024 15:42

Szymekk44 added 4 commits September 21, 2024 12:06

Graphics drivers are public, FileSystemType enum

b84f8a4

Graphics drivers are public, FilsSystemType enum

e80d1e0

Merge pull request #1 from Szymekk44/CGE-Update

e0e7f0b

Cge update

Merge pull request #2 from Szymekk44/CGE-Update2

e58fdc5

Cge update2

Disk format - removed FIleTypeFormat enum

fb59494

Szymekk44 closed this Sep 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CGS Update (part 2) #3034

CGS Update (part 2) #3034

Szymekk44 commented Jun 20, 2024 •

edited

Loading

blackneeed left a comment •

edited

Loading

valentinbreiz left a comment

Szymekk44 commented Jul 8, 2024

Epiczhul commented Jul 20, 2024

Epiczhul left a comment

Epiczhul left a comment

Samma2009 commented Aug 13, 2024

quajak left a comment

quajak Aug 13, 2024

quajak Aug 13, 2024

quajak Aug 13, 2024

quajak Aug 13, 2024

quajak Aug 13, 2024

Samma2009 Aug 13, 2024

quajak Aug 13, 2024

quajak Aug 13, 2024

quajak Aug 13, 2024

Samma2009 Aug 13, 2024

quajak Aug 13, 2024

Samma2009 Aug 13, 2024

Samma2009 commented Aug 13, 2024

Samma2009 commented Aug 16, 2024

Szymekk44 commented Sep 21, 2024


		PCIExpress.Initialize();

		Console.Write("[PCI] PCI Initialized. ");

CGS Update (part 2) #3034

CGS Update (part 2) #3034

Conversation

Szymekk44 commented Jun 20, 2024 • edited Loading

blackneeed left a comment • edited Loading

Choose a reason for hiding this comment

valentinbreiz left a comment

Choose a reason for hiding this comment

Szymekk44 commented Jul 8, 2024

Epiczhul commented Jul 20, 2024

Epiczhul left a comment

Choose a reason for hiding this comment

Epiczhul left a comment

Choose a reason for hiding this comment

Samma2009 commented Aug 13, 2024

quajak left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Samma2009 commented Aug 13, 2024

Samma2009 commented Aug 16, 2024

Szymekk44 commented Sep 21, 2024

Szymekk44 commented Jun 20, 2024 •

edited

Loading

blackneeed left a comment •

edited

Loading