✨CGS Update part 2 (Remastered) #3087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function copies a fragment of your video buffer, and returns it as Bitmap.
quajak
requested changes
Sep 25, 2024
| @@ -35,7 +35,7 @@ private enum VideoDriver | |||
| VGADriver | |||
| } | |||
|
|
|||
| static Canvas videoDriver = null; | |||
| public static Canvas videoDriver = null; | |||
There was a problem hiding this comment.
Why do we need this to be public?
There was a problem hiding this comment.
so you can directly access framebuffer and many driver stuff
- CopyVRAM
- GetVRAM
- SetVRAM
- ClearVRAM
- Fill
Also i think that people should have direct access to grapic driver, only positives
| private Mode mode; | ||
| private readonly VMWareSVGAII driver; | ||
| public Mode mode; | ||
| public readonly VMWareSVGAII driver; |
| readonly VBEDriver driver; | ||
| Mode mode; | ||
| public readonly VBEDriver driver; | ||
| public Mode mode; |
quajak
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This time nice and clean!
Added
Note: I didn't add XML to the override voids, as the others don't have them either. XML comments are always above virtual/abstract voids. Writing this because of my last pr hihi