IconInsets for WButton Icon #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
requested changes
Oct 10, 2022
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
Juuxel
reviewed
Oct 10, 2022
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WButton.java
Outdated
Show resolved
Hide resolved
GuiTest/src/main/java/io/github/cottonmc/test/TestDescription.java
Outdated
Show resolved
Hide resolved
alex-haas
commented
Oct 11, 2022
Juuxel
reviewed
Oct 12, 2022
Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
please accept my small pull request - it just adds proper insets for the Button when both, Icon and Label, are set.
Before:
After:
