Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input/output filter + weaken WPlayerInvPanel's components' protection #209

Merged
merged 8 commits into from
Sep 9, 2023

Conversation

Luligabi1
Copy link
Contributor

  • Deprecates WItemSlot's filter system in favor of input and output filters;
    • The test mod is updated to test this.
  • Weaken WPlayerInvPanel's components (inv, hotbar and label) from private to `protected;
  • Bump some dependencies, as the test mod wouldn't launch without it.

@Luligabi1 Luligabi1 requested a review from Juuxel August 1, 2023 19:22
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with these small changes

gradle.properties Show resolved Hide resolved
Luligabi1 and others added 3 commits August 2, 2023 14:33
Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>
Co-authored-by: Juuz <6596629+Juuxel@users.noreply.github.com>
@Luligabi1 Luligabi1 requested a review from Juuxel August 2, 2023 17:53
@Juuxel Juuxel merged commit 4a63d4e into CottonMC:master Sep 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants