Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll bar getters to WScrollPanel #225

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

tal5
Copy link
Contributor

@tal5 tal5 commented Nov 12, 2023

Adds getters for the vertical and horizontal scroll bars to WScrollPanel, which is useful for things like changing the scroll bar's speed.

Not sure if we want to have setters as well? let me know if that's the case and I can add that in. Setters have been added.

@Juuxel
Copy link
Member

Juuxel commented Nov 13, 2023

Yeah, setters would be useful here - the backing fields are mutable.

@tal5
Copy link
Contributor Author

tal5 commented Nov 13, 2023

Yeah, setters would be useful here - the backing fields are mutable.

Added setters

Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@Juuxel Juuxel merged commit 9dac7f4 into CottonMC:master Nov 13, 2023
1 check passed
@tal5 tal5 deleted the Scroll_Panel_Getters branch June 3, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants