Update to 1.20.6 #242
Merged
Update to 1.20.6 #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Juuxel
reviewed
May 4, 2024
|
|
||
| if (receiver != null) { | ||
| buf.retain(); | ||
| data.buf().retain(); |
There was a problem hiding this comment.
Since the buffer is now created by us, I think this extra retain might leak memory:
- Initial state: refcount = 1
retain: refcount = 2release: refcount = 1 (needs 0 to be deallocated according to NettyReferenceCounteddocs)
Juuxel
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on CottonMC/Jankson-Fabric#23 (or similar)
For the new networking paradigm, I chose to keep the extra
PacketByteBufdata intact to preserve API. A much more robust system would be to usePacketCodecs for that system as well