Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option for WLabel, WText and WDynamicLabel to have shadows #248

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Add option for WLabel, WText and WDynamicLabel to have shadows #248

merged 4 commits into from
Aug 14, 2024

Conversation

MarcusElg
Copy link
Contributor

@MarcusElg MarcusElg commented Aug 3, 2024 •
edited
Loading

Closes #245
Closes #233

Juuxel
Juuxel reviewed Aug 3, 2024
View reviewed changes
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the changes for WLabel look good. Note that this PR doesn't fully address #233 since it's also about the other text widgets which don't support shadows either.

src/main/java/io/github/cottonmc/cotton/gui/widget/WLabel.java Outdated Show resolved Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WLabel.java Outdated Show resolved Hide resolved
@MarcusElg MarcusElg changed the title Add option for WLabel to have shadows Add option for WLabel, WText and WDynamicLabel to have shadows Aug 3, 2024
@MarcusElg
Copy link
Contributor Author

Thanks, the changes for WLabel look good. Note that this PR doesn't fully address #233 since it's also about the other text widgets which don't support shadows either.

Now it does 😉

@Juuxel
Copy link
Member

Juuxel commented Aug 3, 2024

The PR doesn't compile. Could you fix the compilation errors? The other PR's build is also failing.

@MarcusElg MarcusElg requested a review from Juuxel August 4, 2024 07:39
@MarcusElg
Copy link
Contributor Author

MarcusElg commented Aug 8, 2024 •
edited
Loading

@Juuxel could you take a look at this? I would like to use it in my mod 😉

Juuxel
Juuxel approved these changes Aug 8, 2024
View reviewed changes
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor doc typos/fixes.

src/main/java/io/github/cottonmc/cotton/gui/widget/WDynamicLabel.java Outdated Show resolved Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WLabel.java Outdated Show resolved Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WText.java Outdated Show resolved Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WText.java Outdated Show resolved Hide resolved
src/main/java/io/github/cottonmc/cotton/gui/widget/WText.java Outdated Show resolved Hide resolved
@MarcusElg
Copy link
Contributor Author

Fixed

@MarcusElg
Copy link
Contributor Author

@Juuxel sorry for pinging again, but could this be merged now that it's approved?

Juuxel
Juuxel approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@Juuxel Juuxel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@Juuxel Juuxel merged commit 493463e into CottonMC:master Aug 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juuxel Juuxel Juuxel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add variable to enable drawing shadows for WText Support Text shadows in default widgets
2 participants
@MarcusElg @Juuxel