Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing SDK to automatics start session in background #320

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

ijunaid
Copy link
Contributor

@ijunaid ijunaid commented Jul 18, 2024

No description provided.

@@ -354,6 +354,11 @@ - (void)beginSession
CLY_LOG_W(@"%s A session is already running, this 'beginSession' will be ignored", __FUNCTION__);
return;
}

if (!CountlyCommon.sharedInstance.manualSessionHandling && [UIApplication sharedApplication].applicationState == UIApplicationStateBackground) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb we can also add this check to the updateSession

@turtledreams turtledreams merged commit f2213f8 into staging Jul 24, 2024
2 checks passed
@turtledreams turtledreams deleted the session-fixes branch July 24, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants