Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send orientation during initialization and consent given for user det… #323

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Send orientation during initialization and consent given for user det… #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Countly.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ - (void)startWithConfig:(CountlyConfig *)config
if (!CountlyCommon.sharedInstance.manualSessionHandling)
[CountlyConnectionManager.sharedInstance beginSession];

[CountlyCommon.sharedInstance recordOrientation];

//NOTE: If there is no consent for sessions, location info and attribution should be sent separately, as they cannot be sent with begin_session request.
if (!CountlyConsentManager.sharedInstance.consentForSessions)
{
Expand Down
2 changes: 2 additions & 0 deletions CountlyCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ void CountlyPrint(NSString *stringToPrint);

- (void)observeDeviceOrientationChanges;

- (void)recordOrientation;

- (BOOL)hasStarted_;
@end

Expand Down
1 change: 1 addition & 0 deletions CountlyConsentManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ - (void)setConsentForUserDetails:(BOOL)consentForUserDetails
if (consentForUserDetails)
{
CLY_LOG_D(@"Consent for UserDetails is given.");
[CountlyCommon.sharedInstance recordOrientation];
[Countly.user save];
}
else
Expand Down