Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weasyprint 54.1 report issue #2

Closed
wants to merge 2 commits into from
Closed

Fix weasyprint 54.1 report issue #2

wants to merge 2 commits into from

Conversation

FrancoisCapon
Copy link
Contributor

Hi,

I'm building a weasyprint docker image based on Debian 11 and testing the report example:

  • with weasyprint 54.1:

weasyprint-report-01

  • no issue with the weasyprint 53.4

I'm looking the cause of the difference and I find that is a calculation precision issue, with height: 290mm there no issue.

#cover {
  align-content: space-between;
  display: flex;
  flex-wrap: wrap;
  height: 297mm;
  height: 290mm;
}

So, I propose to change the code a bit to avoid using the height of the page to set the positions of the two <address>.

Below the two reports PDF:

@liZe
Copy link
Member

liZe commented Feb 20, 2022

Thanks for the pull request. We’d like to find why the rendering changed, and if possible find a solution that wouldn’t change the HTML document.

@liZe
Copy link
Member

liZe commented Feb 20, 2022

The bug has been fixed in Kozea/WeasyPrint@fe3e3b9, and will be included in WeasyPrint 54.2, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants