Fix deprecation warnings comming from punycode dependency. #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevOpsDave
added
the
release/patch
…rAgentString correctly.
…of node we support.
americk0
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Looks good. The only issue I discovered was with the alks server start command not working, but to be fair I installed an older version of the ALKS cli from before your changes and it still gave me these errors so it looks like this was already broken. Rather than bothering to fix this (since it's legacy and not working currently), maybe we should just remove it in the near future from the ALKS CLI altogether, and if a few people request if back maybe we can fork it into a separate project. Just something to consider, but for now this code looks and runs great as far as I've tested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Log Items
Description
Because prior to node 18, node did not provide an http fetch api so we had to use a 3rd party library for that functionality (request/node-fetch). These 3rd party packages rely on punycode which is being deprecated in node >= v21. This PR will switch over to axios since that will relieve us of the punycode deprecation warnings.
Rally:
US1504256: [Continued] [Continued] alks-cli: Clean deprecation warnings