This repository has been archived by the owner on Nov 9, 2019. It is now read-only.
Move hostcall impl behind a Result<()> fn #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me! I don't have tons of opinions on organization, but I'm assuming that 99% of the movement here isn't changing code and is just |
Yep, you got it! |
alexcrichton
approved these changes
Jul 23, 2019
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses @alexcrichton's great suggestion of moving the implementation of the majority of hostcalls into functions which return a
Result<(), host::__wasi_errno_t>, and thus making use of the?operator to streamline a lot of the processing.NB This PR depends directly on #39, and in turn on #38.