This repository has been archived by the owner on Nov 9, 2019. It is now read-only.
Reuse errno_from_ioerror to simplify error handling #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmistrz
force-pushed
the
error-refactor
branch
from
32899ae
to
42710ae
Compare
6 tasks
|
LGTM! If you don't mind, I'd like to have #41 squashed and rebased onto master first, before we proceed with this one. Is that OK with you? :-) |
|
ok :) |
|
@marmistrz OK, so #41 is now merged. Could you rebase and apply your refactoring to anything that's either new or missed? :-) |
marmistrz
force-pushed
the
error-refactor
branch
from
e79c3b7
to
7b56b5b
Compare
marmistrz
force-pushed
the
error-refactor
branch
from
7b56b5b
to
84ec73f
Compare
|
I updated the change |
|
Great, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bases on #42.