This repository has been archived by the owner on Nov 7, 2019. It is now read-only.
Use the wasi crate. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from depending on libc to depending on the new wasi crate to provide the low-level WASI interfaces. See also rust-lang/libc#1461.
kubkon
approved these changes
Aug 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking for feedback on whether this makes sense: Currently, the Rust
libccrate provides declarations of the low-level WASI interfaces. We recently introduced a newwasicrate which provides these interfaces, and are considering removing them fromlibc. Thewasicrate also provides safe wrappers around thewasifunctions, which we can use here too (although we still do need some of our own wrappers, because it doesn't provide interfaces that usestr, or allow us to test the values written into output parameters in error cases).