CASMCMS-9269: Improve Python type annotations in session templates controller code #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mharding-hpe
requested review from
jsl-hpe,
jsollom-hpe,
rbak-hpe and
kumarrahul04
mharding-hpe
force-pushed
the
casmcms-9269
branch
from
f1597fd to
fd99ce3
Compare
This was referenced Feb 5, 2025
jsollom-hpe
approved these changes
Feb 6, 2025
mharding-hpe
force-pushed
the
casmcms-8965
branch
from
059271a to
618f1d5
Compare
mharding-hpe
force-pushed
the
casmcms-9269
branch
from
fd99ce3 to
30d500b
Compare
mharding-hpe
force-pushed
the
casmcms-8965
branch
from
618f1d5 to
2c843b9
Compare
mharding-hpe
force-pushed
the
casmcms-9269
branch
from
30d500b to
29e866b
Compare
This was referenced Feb 6, 2025
…options, health, versions, and base/utility modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the type annotation work started in this PR. That PR was focused on the sessions controller, this one is focused on the session templates controller. Some functions created by that PR are also useful for this one, so they were moved from their original location into the
controllers.utilsmodule.Like with the other type annotations PR, this one does not change how BOS actually behaves, because Python ignores type annotations at runtime.