Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize list cabinet workflow for multiple providers #161

Merged
merged 1 commit into from
Nov 28, 2023
Merged

generalize list cabinet workflow for multiple providers #161

merged 1 commit into from
Nov 28, 2023

Conversation

jacobsalmela
Copy link
Collaborator

@jacobsalmela jacobsalmela commented Nov 28, 2023 •
edited
Loading

Summary and Scope

  • uses the MergeProviderCommand to remove cray-sauce from the list cabinet workflow and moves it into the provider/csm package
  • updates the provider interface and domain package accordingly

Risks and Mitigations

Low. All existing tests still pass

@jacobsalmela
generalize list cabinet workflow for multiple providers
d791eb2 
Signed-off-by: Jacob Salmela <jacob.salmela@hpe.com>
@jacobsalmela jacobsalmela self-assigned this Nov 28, 2023
@jacobsalmela jacobsalmela marked this pull request as ready for review November 28, 2023 21:22
@jacobsalmela jacobsalmela merged commit c93ebee into develop Nov 28, 2023
5 checks passed
@jacobsalmela jacobsalmela deleted the loving-stormtrooper branch November 28, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shunr-hpe shunr-hpe shunr-hpe approved these changes

Assignees

@jacobsalmela jacobsalmela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobsalmela @shunr-hpe