Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMCMS-9203: Generate unique name for cms-ipxe job #113

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Conversation

kumarrahul04
Copy link
Contributor

Summary and Scope

Post install upgrade job of cms-ipxe is not idempotent

Summarize what has changed. Explain why this PR is necessary. What is impacted? Is this a new feature, critical bug fix, etc?

  • Job name will unique every time a manifest file is created to avoid Job name conflict.

Is this change backwards incompatible, backwards compatible, or a backwards compatible bugfix?
Compatible

Issues and Related PRs

CASMTRIAGE-7492

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

  • Resolves [issue id](issue link)
    https://jira-pro.it.hpe.com:8443/browse/CASMCMS-9203
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

List the environments in which these changes were tested.

Tested on:

  • mug
    • <development system>
    • Local development environment
    • Virtual Shasta

Test description:

Following tests where performed

  1. Successfully deployed cms-ipxe chart 3 times. Tested the name of the Job and it was unique every time. Here are the screenshots
    image
    image
    image

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

Are there known issues with these changes? Any other special considerations?

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

csm-gitflow-merge-back-bot bot and others added 2 commits January 6, 2025 11:18
…-9068-1736183831

[chore] master -> develop from PR #110 (hotfix/CASMCMS-9068)
* Generate unique job name for cms-ipxe

* updated

* updated

* updated

* updated

* updated

* review comments
@kumarrahul04 kumarrahul04 requested a review from a team as a code owner January 13, 2025 18:21
@kumarrahul04 kumarrahul04 requested a review from jsl-hpe January 13, 2025 18:21
@kumarrahul04 kumarrahul04 self-assigned this Jan 13, 2025
@kumarrahul04 kumarrahul04 merged commit 5d76372 into master Jan 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants