Feature/vsha 547 #55
Merged
Feature/vsha 547 #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
mharding-hpe
approved these changes
Apr 10, 2023
|
Thanks! I appreciate the help with the versioning, that was confusing me. |
|
Kudos, SonarCloud Quality Gate passed!
|
No problem. In theory we follow the process defined here: Although there are various deviations from it. |
dlaine-hpe
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Add Helm chart content and code to enable the logic for setting the architecture and type when generating the iPXE binary that has been latent in the code for quite a while. This is needed to used cms-ipxe on vShasta because vShasta uses KPXE binaries not EFI.
Backward compatible change.
Issues and Related PRs
Testing
Tested on:
Test description:
Installed on vShasta v2 system and verified that I could build a KPXE binary using cray-ipxe. Also verified that the chart with no special customizations creates a cray-ipxe that builds an EFI / x86 binary.
Risks and Mitigations
There are no known risks or issues with this change.
Pull Request Checklist