MTL-2380 Fix carriage returns #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustydb
force-pushed
the
MTL-2380
branch
2 times, most recently
from
75277ae to
7a95f6e
Compare
mtupitsyn
reviewed
Feb 27, 2024
Fix carriage returns to properly handle newlines when a single bracket is used in the YAML.
Handle cases where there is no network interface with the VIP index. By default the VIP index is `2`, meaning systems without a `net2` will end up failing this for-loop. Regardless of what the VIP index is, ensure we fallback to the iPXE's natural starting index if the VIP does not exist.
|
mtupitsyn
approved these changes
Feb 27, 2024
heemstra
approved these changes
Feb 28, 2024
mharding-hpe
changed the title
mharding-hpe
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix carriage returns to properly handle newlines when a single bracket is used in the YAML.