Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CASM-3552: Use new api checker for this repo #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CASM-3552: Use new api checker for this repo #9

wants to merge 1 commit into from

Conversation

mitchty
Copy link
Contributor

@mitchty mitchty commented Oct 21, 2022

Summary and Scope

Adding the api checker action.

The action is free, the changes we need for this is not... We need to upgrade all of cert-manager.

Issues and Related PRs

List and characterize relationship to Jira/Github issues and other pull requests. Be sure to list dependencies.

  • Resolves CASM-3552
  • Change will also be needed in <insert branch name here>
  • Future work required by [issue id](issue link)
  • Documentation changes required in [issue id](issue link)
  • Merge with/before/after <insert PR URL here>

Testing

n/a

Tested on:

n/a

Test description:

How were the changes tested and success verified? If schema changes were part of this change, how were those handled in your upgrade/downgrade testing?

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?
  • Were continuous integration tests run? If not, why?
  • Was upgrade tested? If not, why?
  • Was downgrade tested? If not, why?
  • Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations

For the action no risks

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@mitchty mitchty requested a review from a team as a code owner October 21, 2022 17:07
@github-actions
Copy link

Deprecated or removed api's detected, reference upstream documentation for full details on specific api changes:
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-22

The pluto tool, https://pluto.docs.fairwinds.com/ found the following issues:

NAME KIND VERSION DEPRECATED REMOVED REPLACEMENT
certificaterequests.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
certificates.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
challenges.acme.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
clusterissuers.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
issuers.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
orders.acme.cert-manager.io CustomResourceDefinition apiextensions.k8s.io/v1beta1 true true apiextensions.k8s.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-issuer-common Issuer cert-manager.io/v1alpha2 true false cert-manager.io/v1
cert-manager-cainjector ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-issuers ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-clusterissuers ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-certificates ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-orders ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-challenges ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-ingress-shim ClusterRole rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-cainjector ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-issuers ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-clusterissuers ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-certificates ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-orders ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-challenges ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-controller-ingress-shim ClusterRoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-cainjector:leaderelection Role rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager:leaderelection Role rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-cainjector:leaderelection RoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager:leaderelection RoleBinding rbac.authorization.k8s.io/v1beta1 true true rbac.authorization.k8s.io/v1
cert-manager-webhook MutatingWebhookConfiguration admissionregistration.k8s.io/v1beta1 true true admissionregistration.k8s.io/v1
cert-manager-webhook ValidatingWebhookConfiguration admissionregistration.k8s.io/v1beta1 true true admissionregistration.k8s.io/v1
pluto detect-files 
NAME                                     KIND                             VERSION                                DEPRECATED   REMOVED  	 REPLACEMENT                      
certificaterequests.cert-manager.io      CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
certificates.cert-manager.io             CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
challenges.acme.cert-manager.io          CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
clusterissuers.cert-manager.io           CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
issuers.cert-manager.io                  CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
orders.acme.cert-manager.io              CustomResourceDefinition         apiextensions.k8s.io/v1beta1           true         true     	 apiextensions.k8s.io/v1          
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-issuer-common               Issuer                           cert-manager.io/v1alpha2               true         false    	 cert-manager.io/v1               
cert-manager-cainjector                  ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-issuers          ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-clusterissuers   ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-certificates     ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-orders           ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-challenges       ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-ingress-shim     ClusterRole                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-cainjector                  ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-issuers          ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-clusterissuers   ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-certificates     ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-orders           ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-challenges       ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-controller-ingress-shim     ClusterRoleBinding               rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-cainjector:leaderelection   Role                             rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager:leaderelection              Role                             rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-cainjector:leaderelection   RoleBinding                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager:leaderelection              RoleBinding                      rbac.authorization.k8s.io/v1beta1      true         true     	 rbac.authorization.k8s.io/v1     
cert-manager-webhook                     MutatingWebhookConfiguration     admissionregistration.k8s.io/v1beta1   true         true     	 admissionregistration.k8s.io/v1  
cert-manager-webhook                     ValidatingWebhookConfiguration   admissionregistration.k8s.io/v1beta1   true         true     	 admissionregistration.k8s.io/v1

@mitchty
Copy link
Contributor Author

mitchty commented Oct 21, 2022

So fixing the removed api usage here is upgrading cert manager. No easy quick fix on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mitchty