CASMTRIAGE-7424 Remove bond0.mtl0

[rustydb]

Summary and Scope

• Fixes: CASMTRIAGE-7424
• Relates to: Add VLAN management with overlap and re-use checks #432

Issue Type

• Bugfix Pull Request

#432 introduced VLAN checking that changed the default VLAN for the Metal network. This change bypassed the clause in GenInterfaceName for tying the metal network to bond0, instead the metal network was tied to bond0.mtl0.

This caused some strange behavior:

• bond0 was still created by other parts of csi and has a metal IP
• bond0.mtl0 is created and has the same IP as bond0
• dnsmasq gets configured to use bond0.mtl0, which has no routes
• PXE fails

Prerequisites

• I have included documentation in my PR (or it is not required)
• I tested this on internal system (if yes, please include results or a description of the test)
• I tested this on a vshasta system (if yes, please include results or a description of the test)

Idempotency

Risks and Mitigations

This change results in a dnsmasq config for MTL that references the correct interface:

#
## This file was generated by cray-site-init.
#
# MTL:
server=/mtl/
address=/mtl/
domain=nmn,10.1.1.0,10.1.1.213,local
interface-name=pit.mtl,bond0
dhcp-option=interface:bond0,option:domain-search,mtl
interface=bond0
cname=packages.mtl,pit.mtl
cname=packages.local,pit.mtl
cname=registry.mtl,pit.mtl
dhcp-option=interface:bond0,option:dns-server,10.1.1.10
dhcp-option=interface:bond0,option:ntp-server,10.1.1.10
dhcp-option=interface:bond0,option:router,10.1.0.1
dhcp-range=interface:bond0,10.1.1.13,10.1.1.213,10m

[spillerc-hpe]

This doesn't behave as expected as the bond members aren't included in the ifcfg-bond0 config.

#
## This file was generated by cray-site-init.
#
NAME='MTL Bootstrap DHCP Subnet'

# Set static IP (becomes "preferred" if dhcp is enabled)
BOOTPROTO='static'
IPADDR='10.1.1.10/16'
PREFIXLEN='16'

# CHANGE AT OWN RISK:
ETHERDEVICE='bond0'

# DO NOT CHANGE THESE:
VLAN_PROTOCOL='ieee802-1Q'
VLAN='yes'
VLAN_ID=1
ONBOOT='yes'
STARTMODE='auto'

[rustydb]

This doesn't behave as expected as the bond members aren't included in the ifcfg-bond0 config.

#
## This file was generated by cray-site-init.
#
NAME='MTL Bootstrap DHCP Subnet'

# Set static IP (becomes "preferred" if dhcp is enabled)
BOOTPROTO='static'
IPADDR='10.1.1.10/16'
PREFIXLEN='16'

# CHANGE AT OWN RISK:
ETHERDEVICE='bond0'

# DO NOT CHANGE THESE:
VLAN_PROTOCOL='ieee802-1Q'
VLAN='yes'
VLAN_ID=1
ONBOOT='yes'
STARTMODE='auto'

Likely due to more logic keying off of DefaultMTLVlan somewhere, or new behavior from #432.

I'll close this PR in favor of the up-and-coming #434 .