Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMPET-7238:/etc/target/saveconfig.json exists as a dir instead of file #181

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

aasha-hpe
Copy link
Contributor

Summary and Scope

This issue is caused due to hostpath /etc/target/saveconfig.json not existed when iscsi_daemon.yaml was deployed. Mounting '/etc/target/' directory instead of '/etc/target/saveconfig.json' fixed the issue.

Issues and Related PRs

None.

  • Resolves [issue id](issue link): CASMPET-7238
  • Change will also be needed in <insert branch name here>: N/A
  • Future work required by [issue id](issue link): N/A
  • Documentation changes required in [issue id](issue link): N/A
  • Merge with/before/after <insert PR URL here>: N/A

Testing

Tested on both Starlord and Fanta having CSM 1.6.0-alpha.67 installed.

Tested on:

Starlord and Fanta

Test description:

Reproduced the issue when iSCSI was not configured. /etc/target/saveconfig.json directory got created on host as this file was not existed (iSCSI was not configured). When iSCSI was configured via CFS ansible play books, it tried to create /etc/target/saveconfig.json file. But since there was a directory /etc/target/saveconfig.json/ , /etc/target/saveconfig.json/saveconfig.json.temp file got created.

Fix verification: Edited the daemonset "kubectl edit cray-sysmgmt-health-node-exporter-iscsi -n sysmgmt-health" to mount "/etc/target" and issue is not seen.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?: Yes
  • Were continuous integration tests run? If not, why?: TBD
  • Was upgrade tested? If not, why?: TBD
  • Was downgrade tested? If not, why?: N/A
  • Were new tests (or test issues/Jiras) created for this change?: No

Risks and Mitigations

None.

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • [x ] License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

This issue is caused due to hostpath /etc/target/saveconfig.json not
existed when iscsi_daemon.yaml was deployed. Mounting '/etc/target/'
directory instead of '/etc/target/saveconfig.json' fixed the issue.
@aasha-hpe aasha-hpe requested a review from a team as a code owner October 2, 2024 11:15
Copy link

@dborman-hpe dborman-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rambabubolla rambabubolla merged commit 3f6ec7b into master Oct 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants