Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMINST-6387 Fix cray Pyinstaller #104

Merged
merged 1 commit into from
May 24, 2023
Merged

CASMINST-6387 Fix cray Pyinstaller #104

merged 1 commit into from
May 24, 2023

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented May 24, 2023

Summary and Scope

Issue Type

  • Bugfix Pull Request

The pyinstaller build for craycli is producing an invalid binary that returns nothing (no flags or commands produce any output).

This block of code was removed in #100, and part of it needs to be returned.

This also cleans up the dual CONTEXT_SETTING and CONTEXT_SETTINGS.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)
  • I tested this on a vshasta system (if yes, please include results or a description of the test)

RPM works:

8c3614bd6d2f:/mnt # rpm -Uvh craycli-0.81.2.dev1+ge402bd0-1.x86_64.rpm
Preparing...                          ################################# [100%]
Updating / installing...
   1:craycli-0.81.2.dev1+ge402bd0-1   c################################# [100%]
8c3614bd6d2f:/mnt # cray
cray -hUsage: cray [OPTIONS] COMMAND [ARGS]...

  Cray management and workflow tool

Options:
  --version   Show the version and exit.
  -h, --help  Show this message and exit.

Groups:
  artifacts  Manage artifacts in S3
  auth       Manage OAuth2 credentials for the Cray CLI
  badger     Badger Service API
  bos        Boot Orchestration Service
  bss        Boot Script Service
  capmc      Cray Advanced Platform Monitoring and Control (CAPMC)
  cfs        Configuration Framework Service
  config     View and edit Cray configuration properties
  cps        Content Projection Service
  fas        Firmware Action Service
  hsm        Hardware State Manager API
  ims        Image Management Service
  nmd        Node Memory Dump Service
  power      Power Control Service (PCS)
  scsd       System Configuration Service
  sls        System Layout Service
  uas        User Access Service
  vnid       Virtual Network Identifier Daemon

Commands:
  init  Initialize/reinitialize the Cray CLI
8c3614bd6d2f:/mnt # cray -h
cray --helUsage: cray [OPTIONS] COMMAND [ARGS]...

  Cray management and workflow tool

Options:
  --version   Show the version and exit.
  -h, --help  Show this message and exit.

Groups:
  artifacts  Manage artifacts in S3
  auth       Manage OAuth2 credentials for the Cray CLI
  badger     Badger Service API
  bos        Boot Orchestration Service
  bss        Boot Script Service
  capmc      Cray Advanced Platform Monitoring and Control (CAPMC)
  cfs        Configuration Framework Service
  config     View and edit Cray configuration properties
  cps        Content Projection Service
  fas        Firmware Action Service
  hsm        Hardware State Manager API
  ims        Image Management Service
  nmd        Node Memory Dump Service
  power      Power Control Service (PCS)
  scsd       System Configuration Service
  sls        System Layout Service
  uas        User Access Service
  vnid       Virtual Network Identifier Daemon

Commands:
  init  Initialize/reinitialize the Cray CLI
p8c3614bd6d2f:/mnt # cray --help
cray --versionUsage: cray [OPTIONS] COMMAND [ARGS]...

  Cray management and workflow tool

Options:
  --version   Show the version and exit.
  -h, --help  Show this message and exit.

Groups:
  artifacts  Manage artifacts in S3
  auth       Manage OAuth2 credentials for the Cray CLI
  badger     Badger Service API
  bos        Boot Orchestration Service
  bss        Boot Script Service
  capmc      Cray Advanced Platform Monitoring and Control (CAPMC)
  cfs        Configuration Framework Service
  config     View and edit Cray configuration properties
  cps        Content Projection Service
  fas        Firmware Action Service
  hsm        Hardware State Manager API
  ims        Image Management Service
  nmd        Node Memory Dump Service
  power      Power Control Service (PCS)
  scsd       System Configuration Service
  sls        System Layout Service
  uas        User Access Service
  vnid       Virtual Network Identifier Daemon

Commands:
  init  Initialize/reinitialize the Cray CLI

8c3614bd6d2f:/mnt # cray --version
cray, version 0.81.2.dev1+ge402bd0

Idempotency

Risks and Mitigations

The `pyinstaller` build for `craycli` is producing an invalid binary
that returns nothing (no flags or commands produce any output).

This block of code was removed in #100, and part of it needs to be
returned.

This also cleans up the dual `CONTEXT_SETTING` and `CONTEXT_SETTINGS`.
@rustydb rustydb requested review from a team, kosonenj, alanm-hpe, jpdavis-prof and johren-hpe May 24, 2023 19:26
@rustydb rustydb merged commit dfc4885 into master May 24, 2023
@rustydb rustydb deleted the CASMINST-6387 branch May 24, 2023 19:38
rustydb added a commit to Cray-HPE/metal-provision that referenced this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants