CASMCMS-8651: Remove ARS from CLI; Use updated BSS API spec with updated non-ARS link examples #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjendrysik-hpe
approved these changes
May 30, 2023
mharding-hpe
requested review from
jsl-hpe,
jsollom-hpe,
mjendrysik-hpe,
dlaine-hpe,
rbak-hpe and
a team
mharding-hpe
force-pushed
the
CASMCMS-8651
branch
from
b8888f4 to
35b7c87
Compare
mjendrysik-hpe
approved these changes
May 31, 2023
dlaine-hpe
approved these changes
May 31, 2023
shunr-hpe
approved these changes
May 31, 2023
mharding-hpe
force-pushed
the
CASMCMS-8651
branch
2 times, most recently
from
f5ad0a0 to
7488f0b
Compare
|
The hms-bss PR has merged, so this guy is also ready to be merged. |
…ted non-ARS link examples
mharding-hpe
force-pushed
the
CASMCMS-8651
branch
from
7488f0b to
e97cf46
Compare
rbak-hpe
approved these changes
Jun 1, 2023
mharding-hpe
requested review from
kburns-hpe,
johren-hpe,
kimjensen-hpe,
rnoska-hpe,
leliasen-hpe and
cdelatte-hpe
and removed request for
jsl-hpe and
jsollom-hpe
|
@rustydb would love to get this badboy merged today, if possible. |
I pinged CASMPET, inquiring for their stamp and whether they should remain a code owner. |
kburns-hpe
approved these changes
Jun 5, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
ARS has been gone for a long time. It was left in the CLI temporarily as services transitioned away from it. None of this leftover code is required any longer. This PR removes it.
The BSS API spec also had an old outdated reference to ARS in a couple example strings. This has been corrected in the BSS API spec and this PR updates the CLI to use the new spec.
Prerequisites
I ran the unit tests and no errors were encountered.
Risks and Mitigations
Low risk -- ARS has been gone for a LONG time.