Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-5282 Downgrade botocore #91

Merged
merged 1 commit into from
Apr 27, 2023
Merged

CASMTRIAGE-5282 Downgrade botocore #91

merged 1 commit into from
Apr 27, 2023

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Apr 27, 2023

Summary and Scope

Issue Type

  • Bugfix Pull Request

botocore>=1.29.15 contains a change that breaks the cray artifacts buckets list command.

boto3>=1.26 refers to the above, breaking change so it must also be downgraded.

Pin boto3 and botocore to the last good version before the breaking change, until we can more or less fix it.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (if yes, please include results or a description of the test)
  • I tested this on a vshasta system (if yes, please include results or a description of the test)
ncn-m002:~ # export CRAY_CREDENTIALS=/tmp/cmsdev-cray-credentials-file.810384.json
ncn-m002:~ # cray artifacts buckets list --format json
[
  "admin-tools",
  "badger",
  "boot-images",
  "config-data",
  "etcd-backup",
  "fw-update",
  "ims",
  "install-artifacts",
  "nmd",
  "postgres-backup",
  "sat",
  "sds",
  "sls",
  "sma",
  "ssd",
  "ssm",
  "thanos",
  "user",
  "velero",
  "wlm"
]
ncn-m002:~ # cray --version
cray, version 0.80.0.post2.dev1+g7c0872e

Idempotency

Risks and Mitigations

@rustydb rustydb requested a review from a team as a code owner April 27, 2023 19:30
`botocore>=1.29.15` contains a change that breaks the `cray artifacts
buckets list` command.

`boto3>=1.26` refers to the above, breaking change so it must also be
downgraded.

Pin `boto3` and `botocore` to the last good version before the breaking
change, until we can more or less fix it.
@rustydb rustydb merged commit f42542b into master Apr 27, 2023
@rustydb rustydb deleted the CASMTRIAGE-5282 branch April 27, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants