CASMINST-6734: SW_ADMIN_PASSWORD variable is not required to be set for tests anymore #5562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can you please update the licenses. |
Srinivas-Anand-HPE
force-pushed
the
CASMINST-6734
branch
5 times, most recently
from
54259dc to
0238ed1
Compare
Srinivas-Anand-HPE
requested review from
atifsyedali,
leliasen-hpe,
rajeshranganathan-hpe,
Pankhuri-Rajesh and
mharding-hpe
Srinivas-Anand-HPE
requested review from
haroldlongley,
jnowicki-hpe,
nrockershousen,
spillerc-hpe,
GunashekarKM,
sfkramer,
alexanderkingh,
brookshire,
kkelling-hpe and
don-bahls-hpe
rajeshranganathan-hpe
approved these changes
Nov 27, 2024
rajeshranganathan-hpe
approved these changes
Nov 27, 2024
leliasen-hpe
approved these changes
Dec 2, 2024
Pankhuri-Rajesh
approved these changes
Dec 3, 2024
mharding-hpe
approved these changes
Dec 7, 2024
Srinivas-Anand-HPE
added a commit
that referenced
this pull request
Dec 9, 2024
…or tests anymore #5562 (#5591) CASMINST-6734: SW_ADMIN_PASSWORD variable is not required to be set for tests anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Goss tests no longer need the switch admin password set using an environment variable. The tests read the value directly from Vault now.
Rather than using commands which expose credentials to any user looking at the running processes.
It also removes the various places where this value is stored and exported in an environment variable, as this is no longer required for the test (the test reads it directly from Vault).
CASMINST-6734
Checklist
.github/CODEOWNERSwith the corresponding team in Cray-HPE.