Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "MTL-1561 Add GCP mode for supporting GCP NVME" #17

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Dec 3, 2021

Reverts #15

The change of sort -u to sort -h is breaking the sorting of the disks by size and the RAID is going to grab the wrong disks.

+ lsblk
NAME                MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINT
loop0                 7:0    0   4.7G  1 loop  /run/rootfsbase
loop1                 7:1    0   3.2G  0 loop
`-live-overlay-pool 254:0    0    32G  0 dm
loop2                 7:2    0    32G  0 loop
`-live-overlay-pool 254:0    0    32G  0 dm
sda                   8:0    0 447.1G  0 disk
|-sda1                8:1    0   476M  0 part
| `-md127             9:127  0 475.9M  0 raid1
|-sda2                8:2    0  22.8G  0 part
| `-md126             9:126  0  22.8G  0 raid1 /run/initramfs/live
|-sda3                8:3    0 139.7G  0 part
| `-md125             9:125  0 139.6G  0 raid1 /run/initramfs/overlayfs
`-sda4                8:4    0 139.7G  0 part
  `-md124             9:124  0 139.6G  0 raid1
sdb                   8:16   0   1.7T  0 disk
|-sdb1                8:17   0   476M  0 part
| `-md127             9:127  0 475.9M  0 raid1
|-sdb2                8:18   0  22.8G  0 part
| `-md126             9:126  0  22.8G  0 raid1 /run/initramfs/live
|-sdb3                8:19   0 139.7G  0 part
| `-md125             9:125  0 139.6G  0 raid1 /run/initramfs/overlayfs
`-sdb4                8:20   0 139.7G  0 part
  `-md124             9:124  0 139.6G  0 raid1
sdc                   8:32   0 447.1G  0 disk

Observe above that sdb is the larger, ephemeral disk. However it has been adopted as a RAID member.

@rustydb rustydb merged commit 837ea0e into main Dec 3, 2021
@rustydb rustydb deleted the revert-15-MTL-1561-support-GCP-NVME branch December 3, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants