MTL-1561 Add GCP mode for supporting GCP NVME #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
This new toggle will insert the partitioning prefix into all disks,
assuming that the disks are GCP provided NVME.
This implicitly means that only NVME is supported when
metal.gcp-mode
isengaged. We can add logic to handle our full-suite of busses, only if
we have a use in SAS and SATA GCP disks.
Prerequisites
This needs to be tested on GCP and metal, for the new and old behaviors (respectively).
Related PRs:
Idempotency
Risks and Mitigations
This does not bring the full suite of busses to GCP, it only enables NVME for GCP.