Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL-1561 Add GCP mode for supporting GCP NVME #18

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Dec 4, 2021

Summary and Scope

Issue Type
  • RFE Pull Request

This new toggle will insert the partitioning prefix into all disks,
assuming that the disks are GCP provided NVME.

This implicitly means that only NVME is supported when metal.gcp-mode is
engaged. We can add logic to handle our full-suite of busses, only if
we have a use in SAS and SATA GCP disks.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (x) (if yes, please include results or a description of the test)
  • I tested this on vshasta (x) (if yes, please include results or a description of the test)

This needs to be tested on GCP and metal, for the new and old behaviors (respectively).

Related PRs:

Idempotency

Risks and Mitigations

This does not bring the full suite of busses to GCP, it only enables NVME for GCP.

This reverts commit 837ea0e and
includes fixes for the disk selector to omit NVME partitions.
@rustydb rustydb merged commit d650e10 into main Dec 6, 2021
@rustydb rustydb deleted the MTL-1561-support-GCP-NVME branch December 6, 2021 14:14
@rustydb
Copy link
Contributor Author

rustydb commented Dec 6, 2021

ncn-w003 login: root
Password:
l=================     ===============    ==================
\\ . . . . . . .\\   //. . . . . . .\\  |\\. . . . . . . .\\
||. . ._____. . .|| ||. . ._____. . .|| | || . ._____. . .||
|| . .||   ||. _-|| ||-_ .||   \|____|/ | ||-_.||   || . .||
||. . ||   ||-'  || ||  `-||            | ||  `||   ||. . ||
|| . _||   ||    || ||    \|___-'\___   | ||   ||   || . .||
||_-' ||   ||    || ||               |\ | ||   ||   ||'-__||
||    ||   || .===' `===.         .==='.' /==. ||   ||    ||
||    ||   |/    _-'  '_`.==..==='_-'   '-_    \|   ||    ||
||    |/   |/ _-'       `-_/''\_-'         '-_ \|   \|    ||
||.===.'    ''                                      '.===.||
=='    '                                            '    '==
\   _-'                                              '-_   /
 `''                                                    ''`

sncn-w003:~ # lsblk
NAME                       MAJ:MIN RM   SIZE RO TYPE  MOUNTPOINT
loop0                        7:0    0   4.7G  1 loop  /run/rootfsbase
loop1                        7:1    0   3.2G  0 loop
└─live-overlay-pool        254:0    0    32G  0 dm
loop2                        7:2    0    32G  0 loop
└─live-overlay-pool        254:0    0    32G  0 dm
sda                          8:0    0 447.1G  0 disk
├─sda1                       8:1    0   476M  0 part
│ └─md127                    9:127  0 475.9M  0 raid1 /metal/recovery
├─sda2                       8:2    0  22.8G  0 part
│ └─md126                    9:126  0  22.8G  0 raid1 /run/initramfs/live
├─sda3                       8:3    0 139.7G  0 part
│ └─md125                    9:125  0 139.6G  0 raid1 /run/initramfs/overlayfs
└─sda4                       8:4    0 139.7G  0 part
  └─md124                    9:124  0 279.1G  0 raid0
    └─metalvg0-CRAYS3CACHE 254:1    0   200G  0 lvm   /var/lib/s3fs_cache
sdb                          8:16   0 447.1G  0 disk
├─sdb1                       8:17   0   476M  0 part
│ └─md127                    9:127  0 475.9M  0 raid1 /metal/recovery
├─sdb2                       8:18   0  22.8G  0 part
│ └─md126                    9:126  0  22.8G  0 raid1 /run/initramfs/live
├─sdb3                       8:19   0 139.7G  0 part
│ └─md125                    9:125  0 139.6G  0 raid1 /run/initramfs/overlayfs
└─sdb4                       8:20   0 139.7G  0 part
  └─md124                    9:124  0 279.1G  0 raid0
    └─metalvg0-CRAYS3CACHE 254:1    0   200G  0 lvm   /var/lib/s3fs_cache
sdc                          8:32   0   1.7T  0 disk
├─sdc1                       8:33   0  69.8G  0 part  /run/containerd
├─sdc2                       8:34   0 645.5G  0 part  /run/lib-containerd
└─sdc3                       8:35   0 178.8G  0 part  /var/lib/kubelet
ncn-w003:~ # rpm -qa | grep dracut-metal
dracut-metal-luksetcd-1.6.0-1~mtl_1561_adjust_selector~20211204010951.687dbb9.noarch
dracut-metal-dmk8s-1.6.0-1~mtl_1561_adjust_selector~20211204010922.efee73b.noarch
dracut-metal-mdsquash-1.8.0-1~mtl_1561_support_gcp_nvme~20211204010441.f256555.noarch

All expected partitions were created and the correct disks were selected on metal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants