Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL-1285 Pre-reqs. #19

Merged
merged 1 commit into from
Dec 21, 2021
Merged

MTL-1285 Pre-reqs. #19

merged 1 commit into from
Dec 21, 2021

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Dec 21, 2021

Summary and Scope

Issue Type
  • RFE Pull Request

This changes the shebangs to BASH instead of SH in order to promote/enable better/more BASH tooling.

Additionally this adds a more strict requires to help prevent missing binaries for due-diligence.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (x) (if yes, please include results or a description of the test)
  • Shell prompt changed in dracut?
  • Partitions exist on masters, workers, and storage?

Tested on redbull.

ncn-m003:~ # rpm -qa | grep dracut-metal
dracut-metal-luksetcd-1.6.1-1~mtl_1285_rusty~20211210155810.6ae56d9.noarch
dracut-metal-dmk8s-1.6.1-1~mtl_1285_rusty~20211210155809.60faa48.noarch
dracut-metal-mdsquash-1.8.1-1~mtl_1285_rusty~20211210154653.ed45ad7.noarch

Idempotency

Risks and Mitigations

What is less risky, or more risky now - or if your mod fails is there a new risk?

@rustydb rustydb added the enhancement New feature or request label Dec 21, 2021
@rustydb rustydb merged commit cc0ecb6 into main Dec 21, 2021
@rustydb rustydb deleted the MTL-1285-rusty branch December 21, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants