MTL-1590 Wait to Mark SQFSRAID as Ready #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
This resolves a race condition that is witnessed when dracut find our stoeage array before it has been populated with artifacts. That circumstance triggers an early, false postive failure.
This change ceases labeling the SQFS storage array before we have a chance to populate
it with artifacts. Therefore dracut must wait.
Once populated, apply the FSLabel given from the sqfs_drive_authority
(default: SQFSRAID).
Output from a worker booting, starting at the creation of the SQFSRAID array but without the FSLabel:
Prerequisites
Idempotency
Risks and Mitigations
There is less risk for a dracut race condition between metal and dmsquash. dmsquash will no longer steal the SQFS storage area before it's populated, since it can't find it until the FSLabel is applied. The FSLabel is now only applied once the artifacts are pulled.