Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTL-1495 grep was reading "before" and not "after" #23

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

rustydb
Copy link
Contributor

@rustydb rustydb commented Feb 8, 2022

Summary and Scope

Issue Type
  • Bugfix Pull Request

This fixes grep to read from the desired segment, 2 lines after the
matching line. The problem here is grep is/was reading 2 lines before
the matching line, which reads from the wrong mdhandle. That misread
will fool the code to touching the wrong md handles.

Prerequisites

  • I have included documentation in my PR (or it is not required)
  • I tested this on internal system (x) (if yes, please include results or a description of the test)

Idempotency

Risks and Mitigations

This will mitigate waiting on RAIDs during reboots where the reboot was not necessarily clean.

This fixes grep to read from the desired segment, 2 lines after the
matching line. The problem here is grep is/was reading 2 lines before
the matching line, which reads from the wrong mdhandle. That misread
will fool the code to touching the wrong md handles.
@rustydb rustydb requested review from a team, jacobsalmela, heemstra and manderson-hpe and removed request for a team February 8, 2022 17:51
@rustydb rustydb merged commit 3d0fa7f into main Feb 8, 2022
@rustydb rustydb deleted the MTL-1495-fix-grep branch February 8, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants