MTL-1811 Incorrect FSopt Fails to Mount Partitions in SLES15SP4 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option must be to a power-of-2, for some time the allocsize optimization has not been to a power-of-2. Somehow this incorrect option has gone unoticed and XFS mounts have been working fine in both SLES15SP2 and SLES15SP3. However in SLES15SP4 our luck has ran out, this incorrect value (incorrect because it isn't a power of 2) prevents XFS from mounting. It would seem that this value was incorrectly added a long time ago but had gone unnoticed, most XFS optimization guides suggest 131072(k) and our value is missing that trailing "2". 131072 is 2 to the power of 17 (in other words, 131072 log2 = 17). 13107 log2 is not an integer.
|
Confirmed to work, all k8s NCNs on redbull booted successfully with their partitions after baking this RPM into their images. |
heemstra
approved these changes
Jun 22, 2022
It was general xfs optimization, I'll do more digging and add details to the JIRA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Issue Type
allocsize=13107is invalid and has been ignored (perhaps discarded) by xfsprogs in SLES15SP2 and SLES15SP3, in SLES15SP4 this value prevents XFS from mounting.SP3:
SP4:
Somehow between xfsprogs-4.15 and 5.13 the handling of how
allocsizeis enforced has been made more strict. It is not known if our bad value was being honored at all in previous versions of xfsprogs, but we know in our current xfsprogs for SP4 that it causes a fatal error.This PR changes the value to 131072, a valid value which is 2^17.
Prerequisites
Idempotency
Risks and Mitigations
What is less risky, or more risky now - or if your mod fails is there a new risk?