Add file:// support and provide a nerfed library #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustydb
force-pushed
the
feature/local-disk-support-and-cleanup
branch
3 times, most recently
from
90bf74b
to
4405674
Compare
rustydb
force-pushed
the
feature/local-disk-support-and-cleanup
branch
3 times, most recently
from
9376749
to
f90bcdd
Compare
jacobsalmela
approved these changes
Aug 18, 2021
rustydb
force-pushed
the
feature/local-disk-support-and-cleanup
branch
2 times, most recently
from
0a8fbb7
to
09aa5ef
Compare
/lib/metal-lib.sh and /lib/metal-md-lib.sh now exist, the former is safer to include and provides simple functions that all metal-dracut modules may use. The latter is for md-operations (disk and RAID ops). This library is more strict and will die if the environment is not suitable. File support is also added, meaning metal.server=file://mydir?label=MYUSB will result in loading objects off that FSLabel from that directory. CASMINST-2891 always say yes to wiping
rustydb
force-pushed
the
feature/local-disk-support-and-cleanup
branch
from
09aa5ef
to
eca670c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
This PR does 3 things:
new library /lib/metal-lib.sh and /lib/metal-md-lib.sh now exist, the former is
safer to include and provides simple functions that all metal-dracut
modules may use. The latter is for md-operations (disk and RAID ops).
This library is more strict and will die if the environment is not
suitable.
File support is also added, meaning
metal.server=file://mydir?label=MYUSB will result in loading objects off
that FSLabel from that directory.
Cleanup was done, code was cleaned up to be more verbose with warnings and quieter when needed