Shellcheck #65
Merged
Shellcheck #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustydb
force-pushed
the
shellcheck
branch
2 times, most recently
from
a36af4e
to
b4f43b7
Compare
jpdavis-prof
approved these changes
Sep 24, 2024
rustydb
force-pushed
the
shellcheck
branch
3 times, most recently
from
b4422ac
to
1da9145
Compare
The next few commits in this repo will be fixing shellcheck and will break our "sub-packages" (other dracut repos). We should prevent anyone from installing the current versions of dracut-metal-dmk8s and dracut-metal-luksetcd. The very next version of those repos should contain fixes for accommodating the changes made from shellcheck.
Renames the variable to match the configuration's key name.
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes.
`metal_die` uses a `_reset` variable, but only `reset` was declared.
The second argument to `metal_resolve_disk` is being passed through `sed` to remove everything following a `,`, but this argument's value is always an integer (no commas). The `echo | sed` is effectively useless, not to mention confusing to readers.
`METAL_IGNORE_THRESHOLD` is calculated in another script, making it impossible to run `metal_scand` by just sourcing `metal-lig.sh` alone.
Optimize calls; replace `echo | sed` with simple bash string replacements. Check inputs before moving on.
rustydb
added a commit
to Cray-HPE/dracut-metal-luksetcd
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-luksetcd
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-dmk8s
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-luksetcd
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-dmk8s
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-luksetcd
that referenced
this pull request
Sep 27, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
This check does not work in BASH when it is acknowledging POSIX environments, and we haven't hit this issue ever (so now is a good time for it to start happening!)
|
Successfully PXE booted a storage, worker, and master node. Disk booted a master node. |
rustydb
added a commit
to Cray-HPE/dracut-metal-luksetcd
that referenced
this pull request
Oct 1, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
rustydb
added a commit
to Cray-HPE/dracut-metal-dmk8s
that referenced
this pull request
Oct 1, 2024
Use upper-case vars to indicate a variable is exported elsewhere. Fix missing double-quotes. NOTE: This also adopts dracut-metal-mdsquash changes from Cray-HPE/dracut-metal-mdsquash#65 and thus requires dracut-metal-mdsquash>=2.5.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shellcheck issues I had time to fix up while preparing MTL-2454.