Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish artifacts from test_output on CI fail #372

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

ashao
Copy link
Collaborator

@ashao ashao commented Sep 19, 2023

When trying to debug tests on the Github CI, the output from pytest is often insufficient because some errors are written to the redirected stderr and stdout of launched applications. This PR uploads the test_output directory as an artifact of the workflow on failure.

@ashao ashao self-assigned this Sep 19, 2023
@ashao ashao added area: test Issues related to the test suite area: CI/CD Issues related to continuous integration and deployment labels Sep 19, 2023
When trying to debug tests on the Github CI, the output from
pytest is often insufficient because some errors are written to
the redirected stderr and stdout of launched applications. This
PR uploads the test_output directory as an artifact of the
workflow on failure.
@ashao ashao force-pushed the upload_test_artifacts branch from b28ccf2 to 986d85e Compare September 19, 2023 00:27
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #372 (d839e32) into develop (bc7b232) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #372      +/-   ##
===========================================
+ Coverage    88.18%   88.24%   +0.05%     
===========================================
  Files           58       58              
  Lines         3546     3546              
===========================================
+ Hits          3127     3129       +2     
+ Misses         419      417       -2     

Copy link
Member

@MattToast MattToast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!! This seems like something that's been long overdue!

Copy link
Collaborator

@al-rigazzi al-rigazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Issues related to continuous integration and deployment area: test Issues related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants