FormatStyle & Mutability & Sendability & Inlinable #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvalenta
changed the title
|
Brilliant work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR adds:
Foundation.FormatStyle– I tried to support the same API asDate, supporting similar parameters. Since we need to support a protocol where we want different defaults, I felt it was cleaner to just copy the implementations, otherwise we would have to take generic_DateComponentsConvertiblewhich we would then need to make public, and I am not sure it is worth it, since the implementation is quite trivial.Sendable@inlinableacrossvarfor better work withNaiveDatestructures. I understand non-mutability arguments, however, I think we should stick with them in projects and not generic packages that are here to help users. If we wanted to change just one day, I think the API should allow it.