Fix flowing blocks being valid for making a fluid bottomless

[IThundxr]

The check for seeing if a body of fluid is bottomless didn't check if its a source block before adding it to the number of valid blocks

[simibubi]

The visited set is required for the block search not to check any position twice, so would this not end up with the search caught in a loop of flowing blocks?

[IThundxr]

The visited set is required for the block search not to check any position twice, so would this not end up with the search caught in a loop of flowing blocks?

It shouldn't i remember testing this and it being fine but this is quite old, there might be a better way to just disallow flowing blocks from being counted alongside source blocks

[simibubi]

The hose pulley code is quite a maze. It should probably be rebuilt from the ground up as part of a larger refactor

[IThundxr]

The hose pulley code is quite a maze. It should probably be rebuilt from the ground up as part of a larger refactor

Fluid code in general should probably be refactored, theres dozens of issues about it currently with some performance issues aswell, i might take a look at it post 1.21

[simibubi]

I'll postpone this issue for now then. The code is too brittle to mess with on end-of-support versions