Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only make source blocks valid for bottomless pools #6969

Open
wants to merge 3 commits into
base: mc1.20.1/dev
Choose a base branch
from
Open

Only make source blocks valid for bottomless pools #6969

wants to merge 3 commits into from

Conversation

IThundxr
Copy link
Member

@IThundxr IThundxr commented Sep 19, 2024 •
edited
Loading

Fixes #6790

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Sep 19, 2024
@IThundxr IThundxr force-pushed the mc1.20.1/bottomless-fix branch from 6b1531f to a302178 Compare October 8, 2024 16:28
@IThundxr IThundxr changed the base branch from mc1.20.1/dev to mc1.20.1/0.5.1 October 8, 2024 16:28
@IThundxr IThundxr changed the base branch from mc1.20.1/0.5.1 to mc1.20.1/dev October 11, 2024 14:29
@MoePus
Copy link

MoePus commented Oct 18, 2024

In a large water area, if visited has searched maxBlocks, it will not continue searching.
The newly added condition causes the frontier to never be cleared when the water area contains flowing fluid block, causing it to remain in the isSearching state and unable to pump fluids.

@IThundxr IThundxr marked this pull request as draft October 18, 2024 12:57
@IThundxr IThundxr marked this pull request as ready for review November 14, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tracking Issue]: Flowing fluid blocks count as source blocks with hose pulleys
2 participants
@IThundxr @MoePus